code updates for better compatibility with other NumPy versions and to fix some bugs#2
Open
rmandelb wants to merge 4 commits intoptorrey:masterfrom
Open
code updates for better compatibility with other NumPy versions and to fix some bugs#2rmandelb wants to merge 4 commits intoptorrey:masterfrom
rmandelb wants to merge 4 commits intoptorrey:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @ptorrey and @gsnyder206 ,
In the course of trying to run the sunpy code, my students and I encountered some bugs that I have fixed on a fork, and also found that some lines of code did not work with our versions of NumPy. In the latter case, I extended the code on my fork to work with the new versions of NumPy (without breaking its old functionality either). This pull request is to enable you to integrate these changes with your code base, if you are interested.
I also have noted at one place in
sunpy__synthetic_image.pythat an error message says to download a file that doesn't seem to exist. I can't fix that since I don't know where the file actually is, but I've flagged it so you can update it.In case you aren't used to the GitHub interface for viewing code changes, I suggest you click on the tab that says "4 files changed". It lets you see all the changes line-by-line, and you can also see where I've made a comment suggesting an update in
sunpy__synthetic_image.py.I hope this is helpful, but please let me know if you have any questions!